Add node-problem-detector#870
Merged
Merged
Conversation
imjasonh
reviewed
Jun 26, 2023
Contributor
imjasonh
left a comment
There was a problem hiding this comment.
This needs a rebase, and might be worth porting to TF if possible.
bfb1e30 to
d68bdb5
Compare
Contributor
Author
Rebased and ported to TF. Could you please check? @imjasonh |
imjasonh
suggested changes
Jun 29, 2023
Contributor
imjasonh
left a comment
There was a problem hiding this comment.
This needs to have it included in main.tf too
0606c50 to
15289fd
Compare
Contributor
Author
|
Rebased. |
Signed-off-by: Furkan <furkan.turkal@chainguard.dev> Co-authored-by: Batuhan <batuhan.apaydin@chainguard.dev>
15289fd to
1d38a72
Compare
8 tasks
a9c6472 to
c8f8f13
Compare
imjasonh
reviewed
Jul 6, 2023
c8f8f13 to
257a52f
Compare
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
257a52f to
602ec0f
Compare
imjasonh
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
busyboxin the runtime (AFAIK, npd calls some binaries in the runtime), so binary size increased134MB->145MB178 packages, 121 vulnerabilitiesto122 packages, 17 vulnerabilities(Benchmark image: registry.k8s.io/node-problem-detector/node-problem-detector:v0.8.13)
Any dependency we bump here breaks the compatibility directly.
Fixes:
Related:
Pre-review Checklist
Quality Requirements for Images PRs
The items in this checklist should all be checked in the PR with exceptions clearly documented.
The general idea is that to the extent possible, the image should be a drop-in replacement to its public counterpart.
For new image PRs only
If you have an apko.yaml file in this PR you need to follow this checklist, otherwise feel free to remove.
Include tests, sufficient enough that you would trust this image running in production.
Perform manual tests as needed and document your testing results
The version included is the latest GA version of the software
The latest tag points to the newest stable version
There is a dev tag available that includes a shell and apk tools (by depending on 'wolfi-base')
The image runs as
nonrootand GID/UID are set to 65532 or upstream defaultThe image contains the ca-certs bundle if needed
ENTRYPOINT
CMD:
–helpAdd annotations e.g:
docker kill $(docker run -d --rm cgr.dev/chainguard/nginx)Documentation Requirements